@llvm/pr-subscribers-lld-coff

Author: None (kkent030315)

1>lld-link : error : could not open '/EMITTOOLVERSIONINFO:NO': no such file or directory
1>lld-link : error : could not open '/NOVCFEATURE': no such file or directory
1>lld-link : error : could not open '/NOCOFFGRPINFO': no such file or directory

diff --git a/lld/COFF/Options.td b/lld/COFF/Options.td
index 2a82fb5cd8845..bde1f5f950b4b 100644
--- a/lld/COFF/Options.td
+++ b/lld/COFF/Options.td
@@ -353,6 +353,18 @@ def fastfail : F<"fastfail">;
 def kernel : F<"kernel">;
 def pdbcompress : F<"pdbcompress">;
 def emitpogophaseinfo : F<"emitpogophaseinfo">;
+def emittoolversioninfo: B<
+    "emittoolversioninfo",
+    "Emit a tool version info after DOS header (so-called Rich header, default)",
+    "Do not emit a tool version info after DOS header (so-scalled Ricb header)">;
+def novcfeature: B<
+    "novcfeature",
+    "Embeds tool version info in debug directory (default)",
+    "Do not embed tool version info in debug directory">;
+def nocoffgrpinfo: B<
+    "nocoffgrpinfo",
+    "Embeds COFFGRP info in debug directory (default)",
+    "Do not dmbeds COFFGRP info in debug directory">;
 def noexp : F<"noexp">;
 
 def delay : P_priv<"delay">;

@llvm/pr-subscribers-platform-windows

Author: None (kkent030315)

1>lld-link : error : could not open '/EMITTOOLVERSIONINFO:NO': no such file or directory
1>lld-link : error : could not open '/NOVCFEATURE': no such file or directory
1>lld-link : error : could not open '/NOCOFFGRPINFO': no such file or directory

diff --git a/lld/COFF/Options.td b/lld/COFF/Options.td
index 2a82fb5cd8845..bde1f5f950b4b 100644
--- a/lld/COFF/Options.td
+++ b/lld/COFF/Options.td
@@ -353,6 +353,18 @@ def fastfail : F<"fastfail">;
 def kernel : F<"kernel">;
 def pdbcompress : F<"pdbcompress">;
 def emitpogophaseinfo : F<"emitpogophaseinfo">;
+def emittoolversioninfo: B<
+    "emittoolversioninfo",
+    "Emit a tool version info after DOS header (so-called Rich header, default)",
+    "Do not emit a tool version info after DOS header (so-scalled Ricb header)">;
+def novcfeature: B<
+    "novcfeature",
+    "Embeds tool version info in debug directory (default)",
+    "Do not embed tool version info in debug directory">;
+def nocoffgrpinfo: B<
+    "nocoffgrpinfo",
+    "Embeds COFFGRP info in debug directory (default)",
+    "Do not dmbeds COFFGRP info in debug directory">;
 def noexp : F<"noexp">;
 
 def delay : P_priv<"delay">;

@llvm/pr-subscribers-lld

Author: None (kkent030315)

1>lld-link : error : could not open '/EMITTOOLVERSIONINFO:NO': no such file or directory
1>lld-link : error : could not open '/NOVCFEATURE': no such file or directory
1>lld-link : error : could not open '/NOCOFFGRPINFO': no such file or directory

diff --git a/lld/COFF/Options.td b/lld/COFF/Options.td
index 2a82fb5cd8845..bde1f5f950b4b 100644
--- a/lld/COFF/Options.td
+++ b/lld/COFF/Options.td
@@ -353,6 +353,18 @@ def fastfail : F<"fastfail">;
 def kernel : F<"kernel">;
 def pdbcompress : F<"pdbcompress">;
 def emitpogophaseinfo : F<"emitpogophaseinfo">;
+def emittoolversioninfo: B<
+    "emittoolversioninfo",
+    "Emit a tool version info after DOS header (so-called Rich header, default)",
+    "Do not emit a tool version info after DOS header (so-scalled Ricb header)">;
+def novcfeature: B<
+    "novcfeature",
+    "Embeds tool version info in debug directory (default)",
+    "Do not embed tool version info in debug directory">;
+def nocoffgrpinfo: B<
+    "nocoffgrpinfo",
+    "Embeds COFFGRP info in debug directory (default)",
+    "Do not dmbeds COFFGRP info in debug directory">;
 def noexp : F<"noexp">;
 
 def delay : P_priv<"delay">;

Since LLVM does not implement POGO (Profile-guided Optimization, also known as "PGO")

This seems mildly incorrect - LLVM/Clang does support PGO just fine, but it doesn't support the MSVC intermediate files or produce the exact same metadata in the output as MSVC does.

@mstorsjo Thanks for the review. I updated the PR title, does it look like good for you or should I fix something? Let me know :)

I updated the PR title, does it look like good for you or should I fix something?

Thanks! Although it could be good to clarify that those options affect metadata generation for the MSVC style PGO, and LLD doesn't do that. As it stands right now it is very unclear what these options have to do with the statement about PGO support, as the option names don't make that clear at all.

So perhaps instead of this:

LLVM supports PGO (Profile-Guided Optimization) but does not yet have the capability to emit MS-compatible metadata.

We'd have this:

The latter two options affect how MS link.exe generates metadata for its PGO. LLD doesn't generate any such metadata right now (and doesn't work with the MSVC PGO feature), so those options are kept as no-ops.

Then also on another hand; the latter two options are undocumented, right? So there's quite little risk of them being used much in the wild at all (contrary to the first one which is totally understandable to handle).

We'd have this:

The latter two options affect how MS link.exe generates metadata for its PGO. LLD doesn't generate any such metadata right now (and doesn't work with the MSVC PGO feature), so those options are kept as no-ops.

Updated. Thanks for the better one!

Then also on another hand; the latter two options are undocumented, right? So there's quite little risk of them being used much in the wild at all (contrary to the first one which is totally understandable to handle).

Well, there are many projects uses those flags (e.g., UEFI binaries) and I experienced the odd. For example, if I had this cmake setup, it is no way compatible with MSVC toolchain (link.exe) and Clang toolchain (lld-link.exe). This is solvable by putting if statement to those options but that makes the cmake config redundant. It'd be better we just ignore those :)

target_link_options(foo PRIVATE
    # Decrease the binary size
    /EMITTOOLVERSIONINFO:NO
    /EMITPOGOPHASEINFO
    /NOVCFEATURE
    /NOCOFFGRPINFO
)

We'd have this:

The latter two options affect how MS link.exe generates metadata for its PGO. LLD doesn't generate any such metadata right now (and doesn't work with the MSVC PGO feature), so those options are kept as no-ops.

Updated. Thanks for the better one!

Then also on another hand; the latter two options are undocumented, right? So there's quite little risk of them being used much in the wild at all (contrary to the first one which is totally understandable to handle).

Well, there are many projects uses those flags (e.g., UEFI binaries) and I experienced the odd. For example, if I had this cmake setup, it is no way compatible with MSVC toolchain (link.exe) and Clang toolchain (lld-link.exe). This is solvable by putting if statement to those options but that makes the cmake config redundant. It'd be better we just ignore those :)

target_link_options(foo PRIVATE
    # Decrease the binary size
    /EMITTOOLVERSIONINFO:NO
    /EMITPOGOPHASEINFO
    /NOVCFEATURE
    /NOCOFFGRPINFO
)

Ok, fair enough. Thanks! Then I think this one looks good.